[Bug 533167] Review Request: emacs-ecb - Emacs Code Browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=533167

Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |BuildFails

--- Comment #9 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-16 11:44:12 EST ---
I'm not sure if you're indicating that this is ready for review or not.  Did
you want to wait until those flaws are worked out?

While I'm looking, you have inconsistent macro usage in your spec.  If you
really like needless typing and actually want to use things like "%{__install}"
instead of just "install", you must also use "%{__rm}" and "%{__make}".  Or
just contemplate readability and sanity and get rid of the line noise.

Finally, the srpm above fails to build for me:

+ /bin/mkdir -p
/builddir/build/BUILDROOT/emacs-ecb-2.40-0.1.cvs20101021.fc14.x86_64/usr/share/info
+ /usr/bin/install -m 644 info-help/ecb.info
/builddir/build/BUILDROOT/emacs-ecb-2.40-0.1.cvs20101021.fc14.x86_64/usr/share/info
/usr/bin/install: cannot stat `info-help/ecb.info': No such file or directory

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2604528

Please clear the whiteboard if providing a package which builds.  If you think
this package is not yet ready for review, you are welcome to add "NotReady" to
the whiteboard.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.