[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy
bugzilla at redhat.com
bugzilla at redhat.com
Wed Nov 17 04:39:08 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=506425
Ruediger Landmann <r.landmann at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |r.landmann at redhat.com
AssignedTo|nobody at fedoraproject.org |r.landmann at redhat.com
Flag| |needinfo?(aleksey at oscada.or
| |g.ua)
--- Comment #38 from Ruediger Landmann <r.landmann at redhat.com> 2010-11-16 23:39:01 EST ---
Hi Aleksey: just a few more things to look at here:
- = N/A
/ = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[!] Rpmlint output is clean:
===============================================================
$ rpmlint SPECS/lightsquid.spec
SPECS/lightsquid.spec: W: no-%build-section
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
* OK
$ rpmlint SRPMS/lightsquid-1.8-7.fc14.src.rpm
lightsquid.src: W: spelling-error Summary(en_US) analizer -> analyzer,
canalize, nationalizer
* Please correct to "analyzer"; "Small" would also be better than "Little"
here:
%description
%{name} Small and fast Squid log analyzer.
* Also, I suggest:
Summary: Light, small, and fast log analyzer for Squid proxy
* Also, for the subpackage, I suggest:
%package apache
Summary: Web controls for %{name}
Group: Applications/Internet
Requires: %{name} = %{version}-%{release}
Requires: httpd
%description apache
Configuration files and scripts for Apache.
lightsquid.src: W: spelling-error %description -l en_US analizer -> analyzer,
canalize, nationalizer
lightsquid.src: W: strange-permission lightsquid.spec 0600L
* Should be 644
lightsquid.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
$ rpmlint RPMS/noarch/lightsquid-1.8-7.fc14.noarch.rpm
lightsquid.noarch: W: spelling-error Summary(en_US) analizer -> analyzer,
canalize, nationalizer
lightsquid.noarch: W: spelling-error %description -l en_US analizer ->
analyzer, canalize, nationalizer
lightsquid.noarch: E: executable-marked-as-config-file
/etc/cron.daily/lightsquid
* Remove:
%config(noreplace) %{_sysconfdir}/cron.daily/lightsquid
this is not a config file (yes, rpmlint will then complain
"non-conffile-in-etc", but this is expected)
lightsquid.noarch: E: script-without-shebang /etc/cron.daily/lightsquid
* Please fix
lightsquid.noarch: W: no-manual-page-for-binary lightparser.pl
* Unfortunate, but not a blocker
1 packages and 0 specfiles checked; 2 errors, 3 warnings.
$ rpmlint RPMS/noarch/lightsquid-apache-1.8-7.fc14.noarch.rpm
lightsquid-apache.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
===============================================================
[/] Package is named according to the Package Naming Guidelines.
[/] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[/] Package meets the Packaging Guidelines including the Language specific
items
[/] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[!] License field in the package spec file matches the actual license.
License type in spec file: GPLv2
* Files in package state "GNU General Public License as published by the Free
Software Foundation; either version 2 of the License, or (at your option) any
later version", therefore GPLv2+
[/] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
* GPL is in gnugpl.txt
[/] Spec file is legible and written in American English.
[!] Sources used to build the package matches the upstream source, as provided
in the spec URL.
* md5sums do not match:
$ md5sum SOURCES/lightsquid-1.8.tgz
9b7de3d45da769ae058ac06318c56c54 SOURCES/lightsquid-1.8.tgz
$ md5sum ~/Download/lightsquid-1.8.tgz
310a7e16017290232183753d73f3559d /home/rlandmann/Download/lightsquid-1.8.tgz
* Please express Source0 as:
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
[/] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2605683
[/] Package is not known to require ExcludeArch
[/] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly (with the %find_lang macro)
[-] ldconfig called in %post and %postun if required.
[/] Package does not bundle copies of system libraries
[/] Package is not relocatable.
[/] Package must own all directories that it creates.
[/] Package does not contain duplicates in %files.
[/] Permissions on files are set properly
[/] %files section includes a %defattr(...) line
[/] Package consistently uses macros.
[-] Large documentation files are in a -doc subpackage, if required.
[/] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -static subpackage, if present.
[-] Development .so files in -devel subpackage, if present.
[-] -devel packages require base package with full versioning.
[/] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[!] Package does not own files or directories owned by other packages.
* Package should not try to own /usr/sbin/*
* list the documentation files:
%doc version.txt thanks.txt templates.txt readme.txt logformat.txt install.txt
graph.txt gnugpl.txt
[/] Filenames are valid UTF-8
=== SUGGESTED ITEMS ===
[/] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[/] Reviewer should test that the package builds in mock.
Tested through koji
[/] Package should compile and build into binary rpms on all supported
architectures.
Tested on: f14
[?] Package functions as described.
[-] Scriptlets must be sane, if used.
[/] Subpackages other than -devel require the base package as a fully
versioned
dependency
[-] The placement of pkgconfig(.pc) files is correct (normally in -devel)
[-] File based requires are sane.
[!] Package contains man pages for binaries and scripts.
* no, but not a blocker
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list