[Bug 623606] Review Request: gxneur - GTK front-end for X Neural Switcher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=623606

--- Comment #6 from Martin Gieseking <martin.gieseking at uos.de> 2010-11-17 12:27:06 EST ---
(In reply to comment #5)
> > - The files TODO and README are included in the package. However, they are 
> >   empty (already in the source tarball). I see no point in including these 
> >   files then. Maybe you can ask upstream if this is a mistake.
> It may be filled in further releases.

Sure, but currently, they don't contain any information, and we should not
pollute the user's system with useless files. Hence, I recommend to drop them
for now. 

> > - If you update the version of the software you should reset the release number to 1
> Is it required? I prefer enumerate releases through all updates.

It's not a blocker but good practice and recommended by the guidelines:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release


> It depend only from libxnconfig.so.10 and libxneur.so.10, but I require also
> exactly the same version.

Could you elaborate this? Why do the version numbers of gxneur and xneur have
to be the same? Usually, the required xneur package should be picked based on
the soname gxneur was linked against. If the library's API changes, upstream
will certainly bump the soname.


$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
gxneur.src: W: spelling-error Summary(en_US) xneur -> aneurin, neural, neuron
gxneur.src: W: spelling-error %description -l en_US xneur -> aneurin, neural,
neuron
gxneur.x86_64: E: zero-length /usr/share/doc/gxneur-0.10.0/TODO
gxneur.x86_64: E: zero-length /usr/share/doc/gxneur-0.10.0/README
3 packages and 0 specfiles checked; 2 errors, 2 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.