[Bug 653682] Review Request: jemalloc - General-purpose scalable concurrent malloc(3) implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653682

--- Comment #6 from Martin Gieseking <martin.gieseking at uos.de> 2010-11-18 06:12:22 EST ---
Hi Ingvar,

sorry for nagging again, but there are still some things to consider in your
latest spec:

- please add a short comment above Patch0 telling what the patch does

- swap the Groups of base and devel package:
  base package:  System Environment/Libraries
  devel package: Development/Libraries

- Please replace %{_libdir}/libjemalloc.so.1 with 
  %{_libdir}/libjemalloc.so.* to simplify future soname bumps and to ensure 
  that all versioned library variants (if there will be any in the future) get
  packaged.

- drop %{_includedir}/jemalloc/* in %files devel, as the preceding line 
  %{_includedir}/jemalloc already adds the directory including all its contents

- replace %{_mandir}/man3/jemalloc.3.gz with %{_mandir}/man3/jemalloc.3*
  since we should not rely on a specific compression format applied by rpmbuild

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.