[Bug 653467] Review Request: libpagemap - library for utilization of kernel pagemap interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653467

--- Comment #1 from Dan Horák <dan at danny.cz> 2010-11-18 07:15:20 EST ---
formal review is here, see the notes explaining OK* and BAD statuses below:

BAD source files match upstream:
    upstream: 0ef5d79e4910a78ac5f469317e0e30da0c88130a  libpagemap-0.0.1.tar.gz
    srpm: eef5d2f4ca658cb48b4f42f4c636c6ec7dca815b  libpagemap-0.0.1.tar.gz

OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
BAD dist tag is present.
OK license field matches the actual license.
BAD license is open source-compatible (GPLv3+). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
BAD compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
BAD file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in -devel.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.


- the checksum doesn't match between the source included in the srpm and the
one downloaded from Source0 URL
- you should use dist tag in the Release unless you have strong reason for not
doing that
(https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Using_the_.25.7B.3Fdist.7D_Tag
and https://fedoraproject.org/wiki/Packaging:DistTag)
- the license text must be included as %doc
- the Fedora compiler flags are not used
(https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags)
- use the same %defattr(-,root,root,-) for both (sub-)packages
- the man page should use the default permission 0644 inherited from %defattr,
no need to mark it as %doc, it's done automatically by rpm
- the man page should be included in source archive in unpacked form, rpm will
pack it itself, then use "pmap.1*" in the %files section
- be careful when setting the soname for the library as it represents API/ABI
version and is used in autogenerated dependencies
- README should be included as %doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.