[Bug 527462] Review Request: gmpy - Python interface to GMP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527462

--- Comment #33 from Michael J Gruber <mjg at fedoraproject.org> 2010-11-18 08:25:07 EST ---
Now, I don't know what magic removed my review in comment #32. Luckily I had
saved most parts:

OK source files match upstream:
5095f72025132711c472b5a0db6417be13492b6ce09a74dfea9afe27165a6000 
rootplot-1.1.tar.gz

OK package meets naming and versioning guidelines.
NOT OK specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible.
license text not included upstream.
NOT OK latest version is being packaged.
OK BuildRequires are proper.
OK %clean is present.
OK package builds in koji.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2608031
OK package installs properly.
OK rpmlint is silent.
(3 spellcheck warnings which can be ignored.)
OK final provides and requires are sane:
rpm -qp --provides RPMS/noarch/rootplot-1.1-1.fc14.noarch.rpm

rootplot = 1.1-1.fc14

rpm -qp --requires RPMS/noarch/rootplot-1.1-1.fc14.noarch.rpm

/usr/bin/python
numpy
python(abi) = 2.7
python-matplotlib
root-python
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

N/A %check is present and all tests pass:
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
NOT OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
N/A desktop files valid and installed properly.

So the remianing issues are:

- Use macros rather than vars consistently (e.g. buildroot).
- You can use "python" directly.
- The latest upstream version is 2.2.
- Use %{python_sitelib}/root2matplotlib etc. so that you do not own all of
sitelib.

Also, running the first example

http://packages.python.org/rootplot/plot_directive/pyplots/first.py

through python gives

Traceback (most recent call last):
  File "first.py", line 1, in <module>
    import rootplot.root2matplotlib as r2m
ImportError: No module named rootplot.root2matplotlib

Adjusting the import line results in a segmentation violation, which may very
well be ROOT's fault.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.