[Bug 608332] Review Request: rootplot - Plots ROOT data with matplotlib

bugzilla at redhat.com bugzilla at redhat.com
Thu Nov 18 17:02:28 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=608332

--- Comment #5 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-11-18 12:02:27 EST ---
(In reply to comment #4)
> (In reply to comment #3)
> > Actually, the spec file does not mix styles. The only thing this applies is
> > using $RPM_OPT_FLAGS vs %{optflags} and $RPM_BUILD_ROOT vs %{buildroot}. The
> > choice between these is a matter of personal preference.
> 
> It uses different styles for different variables ($RPM_BUILD_ROOT vs.
> %{_bindir}). If that's not a problem I'm fine with it.

Yes, this is no problem. There's no shell variable declared by rpmbuild to
point to %{_bindir}. However, the functions of $RPM_BUILD_ROOT and %{buildroot}
are identical, and so are those of $RPM_OPT_FLAGS and %{optflags}.

> I've heard someone say
> 
> - The %files section needs improvement. The statement
>  %{python_sitearch}/
> ends up owning the system python directory, which is not wanted.
> 
> Is this different?

You had
 %{python_sitearch}/
which indeed ends up owning the system python directory. Here Steve has
 %{python_sitearch}/*
which only ends up owning whatever is in the system python directory of the
buildroot.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list