[Bug 623606] Review Request: gxneur - GTK front-end for X Neural Switcher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=623606

--- Comment #7 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info> 2010-11-18 14:12:32 EST ---
(In reply to comment #6)
> (In reply to comment #5)
> > > - The files TODO and README are included in the package. However, they are 
> > >   empty (already in the source tarball). I see no point in including these 
> > >   files then. Maybe you can ask upstream if this is a mistake.
> > It may be filled in further releases.
> 
> Sure, but currently, they don't contain any information, and we should not
> pollute the user's system with useless files. Hence, I recommend to drop them
> for now. 
Ok, removed if you insist.

> > > - If you update the version of the software you should reset the release number to 1
> > Is it required? I prefer enumerate releases through all updates.
> 
> It's not a blocker but good practice and recommended by the guidelines:
> http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release
I take it into account in the future, but it is not best change now and all
changelog. Furthermore it break update on this particular file (at least for
me).

> > It depend only from libxnconfig.so.10 and libxneur.so.10, but I require also
> > exactly the same version.
> 
> Could you elaborate this? Why do the version numbers of gxneur and xneur have
> to be the same? Usually, the required xneur package should be picked based on
> the soname gxneur was linked against. If the library's API changes, upstream
> will certainly bump the soname.
May be. But I do that for ensure. Both xneur and gxneur released by same
upstream developer and versions with releases synced. I do not want undefined
surprises with that versions mismatch.

> 
> $ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
> gxneur.src: W: spelling-error Summary(en_US) xneur -> aneurin, neural, neuron
> gxneur.src: W: spelling-error %description -l en_US xneur -> aneurin, neural,
> neuron
> gxneur.x86_64: E: zero-length /usr/share/doc/gxneur-0.10.0/TODO
> gxneur.x86_64: E: zero-length /usr/share/doc/gxneur-0.10.0/README
> 3 packages and 0 specfiles checked; 2 errors, 2 warnings.
xneur is name of package and application, so it is normal what spell checker
does not known it. Zero-length files deleted.

http://hubbitus.net.ru/rpm/Fedora13/gxneur/gxneur-0.10.0-4.fc13.src.rpm
http://hubbitus.net.ru/rpm/Fedora13/gxneur/gxneur.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.