[Bug 650604] Review Request: perl-PDF-Haru - Perl interface to Haru Free PDF Library
bugzilla at redhat.com
bugzilla at redhat.com
Fri Nov 19 12:09:40 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650604
--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2010-11-19 07:09:39 EST ---
Homepage Ok.
Source URL Ok.
Source tar ball is original. Ok.
Summary verified from lib/PDF/Haru.pm. Ok.
Licensed verified from lib/PDF/Haru.pm and README. Ok.
FIX: BuildRequire perl(Exporter) explicitly as it can dual-live in standalone
package in the future (lib/PDF/Haru.pm:8,
http://search.cpan.org/~ferreira/Exporter/).
FIX: BuildRequire perl(Autoloader) explicitly as it can dual-live in standalone
package in the future (lib/PDF/Haru.pm:9,
http://search.cpan.org/~smueller/AutoLoader/).
FIX: BuildRequire perl(XSLoader) explicitly as it can dual-live in standalone
package in the future (lib/PDF/Haru.pm:172,
http://search.cpan.org/~saper/XSLoader/).
FIX: BuildRequire perl(constant) explicitly as it can dual-live in standalone
package in the future (lib/PDF/Haru.pm:177,
http://search.cpan.org/~saper/constant/).
Unversioned libharu-devel BuildRequires (README: >= 2.1.0) as all Fedoras
deliver it. Ok.
Description verified from README. Ok.
All tests pass. Ok.
$ rpmlint perl-PDF-Haru.spec ../SRPMS/perl-PDF-Haru-1.00-1.fc14.src.rpm
../RPMS/x86_64/perl-PDF-Haru-1.00-1.fc14.x86_64.rpm
perl-PDF-Haru.src: W: spelling-error %description -l en_US encodings ->
encoding, encoding s, encodes
perl-PDF-Haru.x86_64: W: spelling-error %description -l en_US encodings ->
encoding, encoding s, encodes
perl-PDF-Haru.x86_64: W: spurious-executable-perm
/usr/share/doc/perl-PDF-Haru-1.00/examples/jpeg_demo.pl
perl-PDF-Haru.x86_64: W: spurious-executable-perm
/usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo.pl
perl-PDF-Haru.x86_64: W: spurious-executable-perm
/usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo2.pl
perl-PDF-Haru.x86_64: W: spurious-executable-perm
/usr/share/doc/perl-PDF-Haru-1.00/examples/line_demo.pl
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
FIX: Remove executable bit from examples/* files (put chmod into %prep
section).
$ rpm -pq -lv ../RPMS/x86_64/perl-PDF-Haru-1.00-1.fc14.x86_64.rpm
drwxr-xr-x 2 root root 0 lis 19 12:58
/usr/lib64/perl5/PDF
-rw-r--r-- 1 root root 50487 zář 14 2008
/usr/lib64/perl5/PDF/Haru.pm
drwxr-xr-x 2 root root 0 lis 19 12:58
/usr/lib64/perl5/auto/PDF
drwxr-xr-x 2 root root 0 lis 19 12:58
/usr/lib64/perl5/auto/PDF/Haru
-rwxr-xr-x 1 root root 247448 lis 19 12:58
/usr/lib64/perl5/auto/PDF/Haru/Haru.so
-rw-r--r-- 1 root root 87 lis 19 12:58
/usr/lib64/perl5/auto/PDF/Haru/autosplit.ix
drwxr-xr-x 2 root root 0 lis 19 12:58
/usr/share/doc/perl-PDF-Haru-1.00
-rw-r--r-- 1 root root 99 zář 14 2008
/usr/share/doc/perl-PDF-Haru-1.00/Changes
-rw-r--r-- 1 root root 1115 zář 13 2008
/usr/share/doc/perl-PDF-Haru-1.00/README
drwxr-xr-x 2 root root 0 zář 14 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples
drwxr-xr-x 2 root root 0 zář 14 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples/images
-rw-r--r-- 1 root root 27778 kvě 27 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples/images/gray.jpg
-rw-r--r-- 1 root root 32651 kvě 27 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples/images/rgb.jpg
-rw-r--r-- 1 root root 62042 zář 14 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples/jpeg_demo.pdf
-rwxr-xr-x 1 root root 1310 zář 13 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples/jpeg_demo.pl
-rw-r--r-- 1 root root 3282 zář 14 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples/line_demo.pdf
-rwxr-xr-x 1 root root 6665 zář 14 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples/line_demo.pl
-rw-r--r-- 1 root root 5540 zář 14 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo.pdf
-rwxr-xr-x 1 root root 6409 zář 13 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo.pl
-rw-r--r-- 1 root root 5328 zář 14 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo2.pdf
-rwxr-xr-x 1 root root 4023 zář 13 2008
/usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo2.pl
-rw-r--r-- 1 root root 14531 lis 19 12:58
/usr/share/man/man3/PDF::Haru.3pm.gz
File permissions and layout Ok.
$ rpm -pq --requires ../RPMS/x86_64/perl-PDF-Haru-1.00-1.fc14.x86_64.rpm |sort
|uniq -c
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6()(64bit)
1 libhpdf-2.1.0.so()(64bit)
1 perl(AutoLoader)
1 perl(Carp)
1 perl(constant)
1 perl(Exporter)
1 perl(:MODULE_COMPAT_5.12.2)
1 perl(strict)
1 perl(warnings)
1 perl(XSLoader)
1 perl >= 0:5.008008
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
2 rpmlib(VersionedDependencies) <= 3.0.3-1
1 rtld(GNU_HASH)
$ rpm -pq --provides ../RPMS/x86_64/perl-PDF-Haru-1.00-1.fc14.x86_64.rpm |sort
|uniq -c
1 perl-PDF-Haru(x86-64) = 1.00-1.fc14
1 perl(PDF::Haru) = 1.00
1 perl-PDF-Haru = 1.00-1.fc14
Binary dependencies Ok.
Otherwise, package is in line with Fedora and Perl packaging guidelines. Ok.
Package builds in Fedora 15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2611027). Ok.
Please correct all `FIX' prefixed issues and provide new spec file.
Resolution: Package NOT approved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list