[Bug 585607] Review Request: gnump3d - The GNU Streaming MP3 / OGG Vorbis Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585607

--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-19 09:29:20 EST ---
It's nice that you posted rpmlint output.  However, it's expected that you'll
also address that output.

Also, you missed this one:
  gnump3d.src:14: W: unversioned-explicit-provides perl(gnump3d::readtags)
because it looks like you didn't run rpmlint on the src.rpm.  You should always
do that.

I think all of the rpmlint complaints are justifiable, but it's expected that
you will justify them, not the reviewer.

Does this really have no external dependencies on any kind of mp3 or vorbis
decoder?

Why would you bzip the init and logrotate files?  It doesn't save any space and
only makes them more difficult to inspect.

This does not seem to follow the packaging guidelines for adding the user and
group:  https://fedoraproject.org/wiki/Packaging:UsersAndGroups

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.