[Bug 487281] Review Request: eGroupware - A web-based groupware suite

bugzilla at redhat.com bugzilla at redhat.com
Fri Nov 19 19:01:26 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487281

--- Comment #18 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info> 2010-11-19 14:01:25 EST ---
(In reply to comment #16)
> Thanks; so we probably don't need:
> 
> Provides:  egw-pear = %{version}
> Provides:  egw_pear = %{version}
Yes, if removed Obsoletes it also should be.

> Similarly, I guess we don't need:
> 
> Provides:  egw-core = %{version}
> Provides:  egw-etemplate = %{version}
> Provides:  %{name}-etemplate = %{version}
> 
> for the core package, right?
May be... I think it is atavism.

> I now suggest deleting only the zero-length language files, which are all
> together in this directory. (See below for HTML; I agree with you that HTML is
> not a problem). These empty language files serve absolutely no purpose and only
> add useless cruft to the installation. 
I do not see any advantage for that, but let it be if you want.

> All that aside, unfortunately the SRPM you posted in comment #14 doesn't build:
> 
> http://koji.fedoraproject.org/koji/getfile?taskID=2610482&name=build.log

Build also fixed.

http://hubbitus.net.ru/rpm/Fedora13/gxneur/gxneur-0.10.0-4.fc13.src.rpm
http://hubbitus.net.ru/rpm/Fedora13/gxneur/gxneur.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list