[Bug 585607] Review Request: gnump3d - The GNU Streaming MP3 / OGG Vorbis Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585607

--- Comment #2 from Paulo Roma Cavalcanti <promac at gmail.com> 2010-11-20 05:39:05 EST ---
(In reply to comment #1)
> It's nice that you posted rpmlint output.  However, it's expected that you'll
> also address that output.
> 
> Also, you missed this one:
>   gnump3d.src:14: W: unversioned-explicit-provides perl(gnump3d::readtags)
> because it looks like you didn't run rpmlint on the src.rpm.  You should always
> do that.

gnump3d does not work without this Provide statement, and I do not think it
needs to be versioned.

> 
> I think all of the rpmlint complaints are justifiable, but it's expected that
> you will justify them, not the reviewer.
> 

The others rpmlint complaints are due to the new group and user created, and
the logrotate file is in its appropriate place.

> Does this really have no external dependencies on any kind of mp3 or vorbis
> decoder?

I think not: 

http://www.linux.com/archive/feature/61154

> 
> Why would you bzip the init and logrotate files?  It doesn't save any space and
> only makes them more difficult to inspect.

I unpacked them in the new version.

> 
> This does not seem to follow the packaging guidelines for adding the user and
> group:  https://fedoraproject.org/wiki/Packaging:UsersAndGroups

Well, I just adopted the recommended template now. 

Spec URL: 
http://roma.fedorapeople.org/specs/gnump3d.spec

SRPM URL: http://roma.fedorapeople.org/srpms/gnump3d-3.0-4.fc12.src.rpm


Thnaks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.