[Bug 645760] Review Request: django-ajax-selects - Enables editing of ForeignKey, ManyToMany and simple text fields using the Autocomplete - jQuery plugin.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645760

--- Comment #5 from Domingo Becker <domingobecker at gmail.com> 2010-11-20 09:17:20 EST ---
(In reply to comment #4)
> django-ajax-selects.noarch: W: spelling-error %description -l en_US jQuery -> j
> Query, query, equerry
> django-ajax-selects.noarch: W: spelling-error %description -l en_US plugin ->
> plug in, plug-in, plugging
> django-ajax-selects.src: W: spelling-error %description -l en_US jQuery -> j
> Query, query, equerry
> django-ajax-selects.src: W: spelling-error %description -l en_US plugin -> plug
> in, plug-in, plugging
> 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
> 
> which I think we can ignore.
> 

jQuery and plugin are not English words according to aspell dictionary, but
they are of common use.

> One question remains, the project website states:
> 
> Requirements
>     * Django 1.0 +
>     * jquery 1.26 +
>     * Autocomplete - jQuery plugin 1.0.2
> http://bassistance.de/jquery-plugins/jquery-plugin-autocomplete/
>     * jquery.autocomplete.css (included with Autocomplete) 
> 

By reading the source code, the dependencies are
* Django  
* ajax_select

This module is ajax_select. It includes itself.
js/ajax_select.js is (or should be) part of the site's admin js stack.
Django is mentioned in the dependencies as BuildRequires and Requires.

> and the tarball does not bundle jquery and Autocomplete so I'm wondering how
> this is going to work after installation. 

AutoCompleteXXX classes are introduced by this package. They are not
dependencies. See file ajax_select/fields.py

> Maybe we need to create another
> package for jquery?

This I don't know. 
jQuery is only mention in ajax_select/__init__.py as introduction text, but
it's not used as a class or instance.
Perhaps it's part of the site's admin js stack too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.