[Bug 639636] Review Request: rubygem-poppler - Ruby binding of poppler-glib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639636

--- Comment #4 from Marek Goldmann <mgoldman at redhat.com> 2010-11-20 15:10:27 EST ---
Created attachment 461760
  --> https://bugzilla.redhat.com/attachment.cgi?id=461760
Failed build log on koji

Mamoru, some notes below.

Build failures:

* Build fails for many tests for rawhide. Test are failing with "SocketError:
getaddrinfo: Name or service not known". It looks like there is no Internet
access on koji while building the package. Log attached. Maybe upstream should
attach the pdf to test/ dir to omit loading it from the Internet
(poppler-test-utils.rb, line 25)?

General:

* You use tabs and spaces in the spec file.

Requires:

* BR: rubygems is not required (it is a dependency of other rubygem-* packages)
* (Not sure about this) I think BR: ruby is required, because of:

Executing command: ['bash', '--login', '-c', 'rpmbuild -bs --target i686
--nodeps builddir/build/SPECS/rubygem-poppler.spec']
sh: ruby: command not found

See attached log for more info.

This is everything for now. Hope this helps you a it as this is my first take
on reviewing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.