[Bug 549590] Review Request: php-pChart - A PHP class to build charts.
bugzilla at redhat.com
bugzilla at redhat.com
Sun Nov 21 02:57:15 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549590
--- Comment #16 from David Nalley <david at gnsa.us> 2010-11-20 21:57:12 EST ---
Hi Eric:
So I have come across one concern with stripping the fonts. In pChart.class I
see the two following lines.
var $ErrorFontName = "Fonts/pf_arma_five.ttf";
$this->setFontProperties("tahoma.ttf",8);
Those files of course won't be there if they are stripped out, but it looks to
be 'hardcoding' (albeit with a relative path) the font location.
I see the solution as doing one of two things:
1. symlink the appropriate .ttf files from packages (and require those
packages)
2. patch the .class file to refer to to the fonts in question. (or different
fonts altogether)
Also I think php-common is necessary at a minimum as a require. (don't know
how I missed that earlier.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list