[Bug 655883] Review Request: latexila - Integrated LaTeX Environment for the GNOME desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=655883

--- Comment #2 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2010-11-22 12:17:31 EST ---
Some comments, just by reading the spec file :

* Version conditions in (Build)Requires are usually useless :
     http://fedoraproject.org/wiki/PackagingGuidelines#Requires
  For example, cmake version is >= 2.6.4 in every supported
  Fedora release (>= 12), and even RHEL. Same thing for gtk2. It
  is yet OK for gtksourceview and vala... with these conditions,
  it is clear that your package wouldn't be available for Fedora
  < 14... And Rawhide (!)... Hope you warned upstream about it.

* Requires on gtk2 and gtksourceview must be removed, they are
  detected automatically by rpm (the needed shared libs by the
  program are added as Requires).

* In the %install section, all these mkdir/cp lines can be
  reduced using a loop and install:
     for s in 16 22 24 32 48; do
        install -Dp data/images/app/icon$s.png \
           %{buildroot}%{_datadir}/icons/hicolor/${s}x$s/apps/%{name}.png
     done

* Please consider carefully:
     http://fedoraproject.org/wiki/PackagingGuidelines#Handling_Locale_Files  
  to correctly handle locale files. Thet MUST not be listed in %files.

* You should not use the .gz extension for man pages in %files,
  use the * joker instead (in case the compression format for man
  pages would change).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.