[Bug 604033] Review Request: openemr - Practice Management, Electronic Medical Record

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604033

--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-22 14:35:17 EST ---
This package has a very large number of rpmlint complaint
(script-without-shebang, wrong-script-end-of-line-encoding,
non-executable-script, zero-length, etc.).  You should run rpmlint on your
packages and address the output when you submit your reviews.

The packages build but do not install:

Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch)
           Requires: perl(SL::IS)
Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch)
           Requires: perl(SL::IC)
Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch)
           Requires: perl(SL::User)
Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch)
           Requires: perl(SL::CT)
Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch)
           Requires: perl(sql-ledger.conf)
Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch)
           Requires: perl(SL::Form)
Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch)
           Requires: perl(SL::AA)
Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch)
           Requires: perl(SL::AR)
Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch)
           Requires: perl(SL::HR)

Shouldn't this have a dependency on php-mysql?  How does it interface with the
database otherwise?

The documentation is half of the size of the package; you should probably
consider splitting a separate -doc package unless the documentation is somehow
required to be installed for the package to work.

The package bundles some javascript libraries.  Bundled javascript is generally
permitted, but you must take care of the licensing issues which result.  For
example, DocumentTreeMenu.js has a BSD license, and there is LGPLv2+ code in
calendar_nikki.inc.  Since these files survive intact in the final packages,
their licenses must be accounted for.  You'll probably need to do a full check
of all the files in the package to determine their licenses.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.