[Bug 642858] Review Request: drupal6-footnotes - Allows to easily create automatically numbered footnote references

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642858

Sven Lankes <sven at lank.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(sven at lank.es)     |

--- Comment #6 from Sven Lankes <sven at lank.es> 2010-11-22 15:19:22 EST ---
(In reply to comment #5)

>> [ N/A ] MUST: The spec file MUST handle locales properly. This is done by using
>> the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

> In fact this point does apply here as the package includes
> /usr/share/drupal/modules/footnotes/translations/fr.po
> /usr/share/drupal/modules/footnotes/translations/ja.po
> Better use %find_lang %{name} --all-name.

Correct me if I'm wrong but find_lang only handles "proper" gettext cases where 
the build process compiles the *.po-Files to binary *.mo files. Here the
*.po-Files are used directly and so find_lang cannot be used.

> %define should be %global.

Right. Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.