[Bug 517191] Review Request: php-symfony-symfony - Open-Source PHP Web Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517191

--- Comment #20 from Christof Damian <christof at damian.net> 2010-11-23 02:11:08 EST ---
(In reply to comment #19)
> I was going to take a look at this, but then I realized that the last comment
> was six months ago and the current version upstream seems to be 1.4.8.  Not
> sure if the posted package should be reviewed or not, but I can make some
> random comments:

I haven't updated it because nobody seems to be interested in reviewing it and
everybody who does gives up after a while. The symfony project itself also
doesn't seem to be interested in a package. I will update it this week if
possible.

> Is it normal for .pkgxml/symfony.xml to be over half a meg?  I guess there are
> some two thousand files in the package, so perhaps that's not surprising.

Yes, I think it is normal.

> As far as I can tell, lime really isn't a bundled library.  It seems to have
> been written as part of symfony though it can be used standalone as it has no
> external dependencies.  I guess you could package it separately, but that's not
> much different from many other libraries that are part of a larger package.

OK, that is good. It is shipped in the "vendor" directory, which is usually
reserved for external stuff.

> I do kind of wish we had just allowed "php-channelname" instead of
> "php-channelname-packagename" when the channel name and package name were the
> same.  Unfortunately repeating it looks kind of dumb.

yes, but this is quite common. Maybe the package could at least provide
php-symfony? But this is a package guideline problem and not really a can of
worms I want to open here.

> I wonder if it's worth including the Propel stuff when Propel itself is no
> longer in the distribution.  (It seems to have been orphaned and while it is in
> f13 it's not in f14 or rawhide.)  Or perhaps I'm misunderstanding what the
> sfPropelPlugin stuff is for, since you mention that you're only targeting
> doctrine.

the sfPropelPlugin provides Propel support for symfony and also includes a copy
of the Propel library. I removed the whole thing, because I don't want to
package Propel and new symfony project are usually using Doctrine anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.