[Bug 543718] Review Request: wxmacmolplt - A graphics program for plotting 3-D molecular structures and normal modes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543718

Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|505154(FE-SCITECH)          |
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+

--- Comment #2 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-23 11:43:54 EST ---
I thought I saw on IRC that someone was going to do a review swap for this, but
it's still sitting here in the queue, so...  how about this for a review swap: 
I'll review your package, and you can review any other package.  Deal?

Builds fine and rpmlint is completely silent.  Installs and seems to run fine
as well.

Note the following from desktop-file-install:

/builddir/build/BUILDROOT/wxmacmolplt-7.4.1-1.fc15.x86_64/usr/share/applications/wxmacmolplt.desktop:
error: (will be fatal in the future): value "Chemistry" in key "Categories" in
group "Desktop Entry" requires another category to be present among the
following categories: Education;Science

/builddir/build/BUILDROOT/wxmacmolplt-7.4.1-1.fc15.x86_64/usr/share/applications/wxmacmolplt.desktop:
error: (will be fatal in the future): value "DataVisualization" in key
"Categories" in group "Desktop Entry" requires another category to be present
among the following categories: Education;Science

/builddir/build/BUILDROOT/wxmacmolplt-7.4.1-1.fc15.x86_64/usr/share/applications/wxmacmolplt.desktop:
error: (will be fatal in the future): value "Science" in key "Categories" in
group "Desktop Entry" requires another category to be present among the
following categories: Education

It's probably better to just fix those up now.  It should be an easy fix, so
I'll go ahead and approve this and you can take care of it when you check in.

* source files match upstream.  sha256sum:
  61c6a785e9d9b5430fde87d75c7e617637c8a2182741792384c723adcbbae34e
   MacMolPltIcon.gif
  46f594aa33f6e90b79a9ebc4c27e4819749397854aca7c594b79226419c76e63
   wxmacmolplt-7.4.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   wxmacmolplt = 7.4.1-1.fc15
   wxmacmolplt(x86-64) = 7.4.1-1.fc15
  =
   /bin/sh  
   hicolor-icon-theme  
   libGL.so.1()(64bit)  
   libGLEW.so.1.5()(64bit)  
   libGLU.so.1()(64bit)  
   libgcc_s.so.1()(64bit)  
   libgcc_s.so.1(GCC_3.0)(64bit)  
   libstdc++.so.6()(64bit)  
   libstdc++.so.6(CXXABI_1.3)(64bit)  
   libstdc++.so.6(CXXABI_1.3.1)(64bit)  
   libstdc++.so.6(GLIBCXX_3.4)(64bit)  
   libstdc++.so.6(GLIBCXX_3.4.11)(64bit)  
   libstdc++.so.6(GLIBCXX_3.4.14)(64bit)  
   libstdc++.so.6(GLIBCXX_3.4.9)(64bit)  
   libwx_baseu-2.8.so.0()(64bit)  
   libwx_baseu-2.8.so.0(WXU_2.8)(64bit)  
   libwx_gtk2u_adv-2.8.so.0()(64bit)  
   libwx_gtk2u_adv-2.8.so.0(WXU_2.8)(64bit)  
   libwx_gtk2u_core-2.8.so.0()(64bit)  
   libwx_gtk2u_core-2.8.so.0(WXU_2.8)(64bit)  
   libwx_gtk2u_gl-2.8.so.0()(64bit)  
   libwx_gtk2u_gl-2.8.so.0(WXU_2.8)(64bit)  
   libwx_gtk2u_html-2.8.so.0()(64bit)  
   libwx_gtk2u_html-2.8.so.0(WXU_2.8)(64bit)  

* no bundled libraries.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* scriptlets are OK (gtk icon cache)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
X desktop file has a few problems.

APPROVED, just fix up the desktop file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.