[Bug 513320] Review Request: boxbackup - A fast, secure and automatic online backup system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513320

--- Comment #19 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-23 12:44:12 EST ---
I thought I saw on IRC that someone was going to review this last week, but
nothing seems to have happened so I'll make some further comments.

The makefile hides important data; adding 'V=1' to the make call makes it more
useful.

I'll trust the previous licensing work and assume that license tag and such are
correct.

Your scriptlets don't seem to correspond to the recommended ones from
http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets
It seems to me that you do the restart on upgrade at the wrong time.  It should
be in the new package %post, not the old package %preun.  What you have
restarts the old server, uninstalls it and installs the new one.  (Of course,
the whole initscript thing is changing for f15, but we don't have any systemd
guidelines yet).

Here's the rpmlint output:
  boxbackup.x86_64: E: non-standard-dir-perm /etc/boxbackup/bbackupd 0700L
  boxbackup.x86_64: W: incoherent-subsys /etc/rc.d/init.d/bbackupd $prog
  boxbackup.x86_64: W: incoherent-subsys /etc/rc.d/init.d/bbackupd $prog
  boxbackup.x86_64: W: incoherent-init-script-name bbackupd
   ('boxbackup', 'boxbackupd')
These are all OK.

  boxbackup-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug
   /boxbackup-0.11rc8/lib/win32/getopt.h
It's odd that the header is executable, and doubly odd that it's in the package
at all.  Why is the stuff in lib/win32 being built?


(cd ../../lib/win32; make -q RELEASE=1 NODEPS=1 || make RELEASE=1 NODEPS=1)
make[2]: Entering directory `/builddir/build/BUILD/boxbackup-0.11rc8/lib/win32'
g++ -DBOX_RELEASE_BUILD -O2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-Wall -Wundef 
-DBOX_VERSION="\"0.11rc8\""  -DBOX_MODULE="\"lib/win32\"" -c emu.cpp -o
../../release/lib/win32/emu.o
g++ -DBOX_RELEASE_BUILD -O2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-Wall -Wundef -DBOX_VERSION="\"0.11rc8\""  -DBOX_MODULE="\"lib/win32\"" -c
getopt_long.cpp -o ../../release/lib/win32/getopt_long.o
(echo -n > ../../release/lib/win32/win32.a; rm ../../release/lib/win32/win32.a)
ar cq ../../release/lib/win32/win32.a ../../release/lib/win32/emu.o
../../release/lib/win32/getopt_long.o
ranlib ../../release/lib/win32/win32.a
make[2]: Leaving directory `/builddir/build/BUILD/boxbackup-0.11rc8/lib/win32'

  boxbackup-server.x86_64: W: non-standard-uid /etc/boxbackup/bbstored
boxbackup
  boxbackup-server.x86_64: E: non-standard-dir-perm
   /etc/boxbackup/bbstored 0700L
  boxbackup-server.x86_64: W: incoherent-subsys /etc/rc.d/init.d/bbstored $prog
  boxbackup-server.x86_64: W: incoherent-subsys /etc/rc.d/init.d/bbstored $prog
  boxbackup-server.x86_64: W: incoherent-init-script-name bbstored
   ('boxbackup-server', 'boxbackup-serverd')
These are all OK.

Why are the files in /etc/boxbackup/ completely empty?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.