[Bug 655527] Review Request: pyside-tools - Development tools for PySide

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=655527

--- Comment #3 from Kalev Lember <kalev at smartlink.ee> 2010-11-23 14:13:10 EST ---
Thanks for your quick review, Steve!

(In reply to comment #2)
> Issues:
> 
> 1.   pysideuic/elementtree/ElementTree.py at a quick look to looks to be a copy
> of 
>      $ rpm -qf /usr/lib64/python2.6/xml/etree/ElementTree.py
> python-2.6.4-27.fc13.x86_64
> 
>       Can the private copy be removed and this also would allow you to drop a
> license maybe.

Good idea. uiparser.py first tries to load Python's copy of ElementTree and
only if that fails it tries the bundled copy, so it's safe to remove the
bundled copy as the version of Python we have in Fedora is recent enough.

Updated %prep section to remove the bundled copy of ElementTree.


> 2. It seems the pysideuic is BSD as well. Can this be reflected in the License
> tag.
> 
>      I might worth a comment stating which part of the code is LICENSE-rcc and
> which
>      is LICENSE-uic.

Looks like uic was dual-licensed at some point in the past and LICENSE-uic
includes the historical license text. In this source tarball, however, all the
source files in pysideuic/ directory (except for ElementTree) have been
re-licensed as GPLv2-only, so it's really no longer BSD.

Added a comment in the spec file explaining the situation.


>      Of course this could be split into subpackages with different licenses
> which I believe
>      is the recommended way in the guidelines.

It's all GPLv2 now that we got rid of bundled ElementTree.


* Tue Nov 23 2010 Kalev Lember <kalev at smartlink.ee> - 0.2.2-2
- Remove bundled ElementTree library in prep (#655527)
- Updated License tag to reflect bundled ElementTree removal

Spec URL: http://kalev.fedorapeople.org/pyside-tools.spec
SRPM URL: http://kalev.fedorapeople.org/pyside-tools-0.2.2-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.