[Bug 644809] Review Request: rubygem-webrat - Ruby Acceptance Testing for Web applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644809

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-11-23 14:18:37 EST ---
Some notes:

* rpmlint issues
  - Please suppress the following rpmlint issues
----------------------------------------------------------
rubygem-webrat-doc.noarch: E: script-without-shebang
/usr/lib/ruby/gems/1.8/gems/webrat-0.7.2/spec/private/core/configuration_spec.rb
rubygem-webrat-doc.noarch: E: script-without-shebang
/usr/lib/ruby/gems/1.8/gems/webrat-0.7.2/spec/private/core/link_spec.rb
rubygem-webrat-doc.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/webrat-0.7.2/spec/integration/merb/tasks/merb.thor/app_script.rb
0644L /usr/bin/env
----------------------------------------------------------

* Documents
  - I guess %geminstdir/install.rb can be moved to -doc subpackage

! Vendorlized jar file
  - Vendorlized jar file unpacked from gem file are surely removed. However
    this jar file is still included in gem file installed under
%{gemdir}/cache/
    and this makes the rebuilt binary rpm unneededly large.

    Would you
    - remove vendor/ (as it is)
    - fix webrat.gemspec and remove vendor/ entry
    - and recreate gem file by "$ thor :build"
    to reduce the size of gem file?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.