[Bug 518546] Review Request: libva - VAAPI video playback acceleration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518546

--- Comment #56 from Adam Williamson <awilliam at redhat.com> 2010-11-23 20:13:05 EST ---
"  libva-devel.x86_64: E: useless-provides libva-devel
Packages automatically provide themselves; there is no point in doing it
manually."

that's just another left-over from the rpmfusion libva-freeworld obsoleting my
side repo libva; i'll fix it.

"Those libraries are all linked against things they don't actually call.  This
isn't generally a big problem unless it causes additional dependencies or
forces libraries to be pulled into memory that otherwise wouldn't be there.  It
can usually be fixed by passing --as-needed into the linker."

I thought that was already done in our default optflags?

"Seems better living in a libva-utils package, honestly, but perhaps I've
failed to properly understand multilib."

This isn't really Fedora policy, most things aren't multilib in Fedora and we
don't apparently split libs from binaries as a matter of course. Only things
you might actually want to install the 32-bit version of on a 64-bit system are
explicitly marked multilib. I can't see any reason you'd want to do that with
libva.

"It would be nice to have more explicit instructions for modifying the tarball. 
Otherwise the next person who has to do it risks letting the prohibited bits
back in."

What do you think is missing? The comments list the entire sequence. The only
thing you have to figure out for yourself is how to 'rediff
108_drivers_path.patch' but it's inherently difficult to explain that exactly
because it may change between releases. All the other changes are consequences
of the steps listed in the comments, there's nothing left out. Try it yourself
and you'll see. (the 'autoreconf -i' step causes most of the changes). AIUI
running autoreconf in the spec would not be optimal because it would leave some
i965 references in the tarball, they aren't purged until the autoreconf step is
run.

"I don't know if you intend to target RHEL4 or 5 with this, but if not you can
drop BuildRoot, %clean and the first line of %install."

yeah, I know, I guess I'll do that. Though someone might want to pull it into
EPEL, I guess, and they're not doing much harm.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.