[Bug 631964] Review Request: pbs_python - PBS/Torque python module

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 24 15:55:05 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=631964

Kalev Lember <kalev at smartlink.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kalev at smartlink.ee
               Flag|                            |fedora-review?

--- Comment #4 from Kalev Lember <kalev at smartlink.ee> 2010-11-24 10:55:04 EST ---
Taking for review.

Instead of pbs_python, I think it would be more natural to call this package
python-pbs and name the subpackages respectively python26-pbs and python3-pbs.
Rationale:
 - Python naming guidelines suggest to use the format python-$NAME [1];
 - Naming guidelines prefer '-' as separator [2];
 - If Debian eventually gets around to packaging this, then the binary package
   will be named python-pbs as their guidelines are stricter. For consistency
   it might be nice to keep the naming similar.

[1]
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29
[2] http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Separators


There are lots of conditionals similar to this:
%if %{?rhel}%{!?rhel:0} == 5
I'd suggest to use the following, more readable conditional instead:
%if 0%{?rhel} == 5

See http://fedoraproject.org/wiki/Packaging/DistTag#Conditionals


> # We need to filter _pbs.so out from the provides.
> Source100:     filter-provides.sh
> %global        _use_internal_dependency_generator 0
> %global        __find_provides /bin/bash %{SOURCE100}

I didn't really read the filter-provides.sh, but if you are just trying to
filter the _pbs.so Provides from Python private directory, it's easier to use:
%{?filter_provides_in: %filter_provides_in %{python_sitearch}/pbs/.*\.so}
%{?filter_setup}

https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Preventing_files.2Fdirectories_from_being_scanned_for_provides_.28pre-scan_filtering.29

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list