[Bug 578024] Review Request: ingres - Relational DBMS Server and Utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578024

--- Comment #36 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-24 15:12:17 EST ---
I'm not sure what's happening with this package, but I went ahead and pulled
the srpm and do have a couple of questions.

No parallel make (or jam, I guess)?  Sure takes a long time to build, letting
all those cores on my builder sit idle.  I see that jam takes -j; that means
that you should be able to use %{?_smp_mflags} to properly parallelize. 
Assuming that of course the makefiles/jamfiles are properly written.

Is there a way to get the actual compiler output instead of the sanitized
output?  I have a suspicion that the compiler flags are not correct since you
don't use %configure and there's no mention of %optflags or $RPM_OPT_FLAGS
anywhere in the spec.  Unfortunately the build process doesn't display them so
it's tough to tell.  I see dbgbuild.patch but it doesn't use anything close to
the proper flags so I'm not sure what it's about.

Why would this require prelink at build time?

Man, it's still building.  (Ten minutes later.)  Still building.  Really,
parallel make/jam/whatever.  Please.

The scriptlets for setting up/restarting the service and for adding the users
do not correspond to the ones in the packaging guidelines.  
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets
https://fedoraproject.org/wiki/Packaging:UsersAndGroups
Besides, I doubt all of the setup stuff that's done at package install time is
really something we want to do.  Why not do all that ahead of time and just put
the files into the package?

There are a while bunch of files installed into /usr/bin which are very
generically named, like /usr/bin/usermod and seem to have nothing to do with
ingres.  I would really suggest prefixing these with something (some use "ing")
or otherwise indicating that they're part of your package and not, say, the
usermod that's in shadow-utils.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.