[Bug 585598] Review Request: python26-PyXML - XML libraries for python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585598

Kevin Fenzi <kevin at tummy.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Kevin Fenzi <kevin at tummy.com> 2010-11-24 19:46:10 EST ---
Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Package is named according to the Package Naming Guidelines. [1]
[x]  Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x]  Spec file is legible and written in American English.
[x]  Spec file lacks Packager, Vendor, PreReq tags.
[x]  Spec uses macros instead of hard-coded directory names.
[x]  Package consistently uses macros.
[x]  Macros in Summary, %description expandable at SRPM build time.
[x]  PreReq is not used.
[x]  Requires correct, justified where necessary.
[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines. [2]
[x]  Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)).
[x]  Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the beginning of
%install.
[x]  Package use %makeinstall only when ``make install DESTDIR=...'' doesn't
work.
[x]  Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x]  Changelog in prescribed format.
[!]  Rpmlint output is silent.
[x]  License field in the package spec file matches the actual license.
[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]  License file installed when any subpackage combination is installed.
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[3,4]
[x]  Sources contain only permissible code or content.
[x]  Sources used to build the package matches the upstream source, as provided
in the spec URL.

1f7655050cebbb664db976405fdba209  PyXML-0.8.4.tar.gz
1f7655050cebbb664db976405fdba209  PyXML-0.8.4.tar.gz.orig


[x]  Compiler flags are appropriate.
[x]  %build honors applicable compiler flags or justifies otherwise.
[x]  Package must own all directories that it creates.
[x]  Package does not own files or directories owned by other packages.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly.
[x]  Each %files section contains %defattr.
[x]  No %config files under /usr.
[x]  Package contains code, or permissable content.
[x]  File names are valid UTF-8.
[x]  Package uses nothing in %doc for runtime.
[x]  Package contains no bundled libraries.
[x]  Useful -debuginfo package or justification otherwise.
[x]  Rpath absent or only used for internal libs.
[x]  Package does not genrate any conflict.
[x]  Package is not relocatable.
[x]  Package is not known to require ExcludeArch.
[x]  Package installs properly.
[x]  Package obeys FHS, except libexecdir and /usr/target.
[x]  Package meets the Packaging Guidelines. [6]

=== SUGGESTED ITEMS ===
[x]  Package functions as described.
[x]  SourceX is a working URL.
[x]  SourceX / PatchY prefixed with %{name}.
[x]  Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]  Reviewer should test that the package builds in mock.
[x]  Package should compile and build into binary rpms on all supported
architectures.
[x]  Dist tag is present.
[x]  Spec use %global instead of %define.
[x]  Scriptlets must be sane, if used.
[x]  No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.

=== Issues ===
1. It doesn't build. ;) 

You need to add 'python26-devel' to BuildRequires. 

2. rpmlint says: 
python26-PyXML.i386: W: no-manual-page-for-binary xmlproc_parse26
python26-PyXML.i386: W: no-manual-page-for-binary xmlproc_val26
python26-PyXML.i386: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/_xmlplus/dom/de/LC_MESSAGES/4Suite.mo
python26-PyXML.i386: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/_xmlplus/dom/en_US/LC_MESSAGES/4Suite.mo
python26-PyXML.i386: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/_xmlplus/dom/fr/LC_MESSAGES/4Suite.mo

I think those can all probibly be ignored. 

You can add the BuildRequires before importing, I see nothing else that 
looks like a blocker here, so this package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.