[Bug 656084] Review Request: perl-CDB_File - Perl extension for access to cdb databases

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=656084

--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2010-11-25 08:04:58 EST ---
Source tar ball is original. Ok.
Summary verified from CDB_File.pm. Ok.
License verified from COPYRIGHT. Ok.
Description verified from CDB_File.pm. Ok.

FIX: BuildRequire perl(Exporter) as it can dual-live in the future
(CDB_File.pm:8, http://search.cpan.org/~ferreira/Exporter/)
FIX: BuildRequire perl(Test) as it can dual-live in the future (t/01main.t:2,
http://search.cpan.org/~jesse/Test/)

All tests pass. Ok.

$ rpmlint perl-CDB_File.spec ../SRPMS/perl-CDB_File-0.96-1.fc14.src.rpm
../RPMS/x86_64/perl-CDB_File-*
perl-CDB_File.src: W: spelling-error Summary(en_US) cdb -> cd, db, cab
perl-CDB_File.src: W: spelling-error %description -l en_US cdb -> cd, db, cab
perl-CDB_File.x86_64: W: spelling-error Summary(en_US) cdb -> cd, db, cab
perl-CDB_File.x86_64: W: spelling-error %description -l en_US cdb -> cd, db,
cab
3 packages and 1 specfiles checked; 0 errors, 4 warnings.

rpmlint Ok.

$ rpm -pqlv ../RPMS/x86_64/perl-CDB_File-0.96-1.fc14.x86_64.rpm 
-rw-r--r--    1 root    root                    10339 bře 21  2008
/usr/lib64/perl5/CDB_File.pm
drwxr-xr-x    2 root    root                        0 lis 25 13:45
/usr/lib64/perl5/auto/CDB_File
-rwxr-xr-x    1 root    root                    33224 lis 25 13:45
/usr/lib64/perl5/auto/CDB_File/CDB_File.so
-rwxr-xr-x    1 root    root                     1062 pro  5  2002
/usr/lib64/perl5/bun-x.pl
drwxr-xr-x    2 root    root                        0 lis 25 13:45
/usr/share/doc/perl-CDB_File-0.96
-rw-r--r--    1 root    root                      988 pro  5  2002
/usr/share/doc/perl-CDB_File-0.96/ACKNOWLEDGE
-rw-r--r--    1 root    root                     3096 bře 21  2008
/usr/share/doc/perl-CDB_File-0.96/CHANGES
-rw-r--r--    1 root    root                      131 pro  5  2002
/usr/share/doc/perl-CDB_File-0.96/COPYRIGHT
-rw-r--r--    1 root    root                      340 dub  2  2003
/usr/share/doc/perl-CDB_File-0.96/README
-rw-r--r--    1 root    root                     5868 lis 25 13:45
/usr/share/man/man3/CDB_File.3pm.gz

File permissions and layout Ok.

$ rpm -pq --requires ../RPMS/x86_64/perl-CDB_File-0.96-1.fc14.x86_64.rpm | sort
| uniq -c
      1 libc.so.6(GLIBC_2.2.5)(64bit)  
      1 libc.so.6(GLIBC_2.4)(64bit)  
      1 libc.so.6()(64bit)  
      1 perl(Carp)  
      1 perl(CDB_File)  
      1 perl(DynaLoader)  
      1 perl(Exporter)  
      1 perl(:MODULE_COMPAT_5.12.2)  
      1 perl(strict)  
      1 perl(vars)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      2 rpmlib(VersionedDependencies) <= 3.0.3-1
      1 rtld(GNU_HASH)  
      1 /usr/bin/perl  

$ rpm -pq --provides ../RPMS/x86_64/perl-CDB_File-0.96-1.fc14.x86_64.rpm | sort
| uniq -c
      1 perl-CDB_File(x86-64) = 0.96-1.fc14
      1 perl(CDB_File) = 0.96
      1 perl-CDB_File = 0.96-1.fc14

$ resolvedeps-f15 ../RPMS/x86_64/perl-CDB_File-*
Binary dependencies Ok.

Otherwise, package is in line with Fedora and perl packaging guidelines.

Package ??? builds in F-15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2625737). ???


Please correct all `FIX' prefixed issues and provide new spec file.
Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.