[Bug 631964] Review Request: python-pbs - PBS/Torque python module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=631964

--- Comment #7 from Kalev Lember <kalev at smartlink.ee> 2010-11-25 09:19:14 EST ---
Fedora review python-pbs-4.3.0-3.fc13.src.rpm 2010-11-25

+ OK
! needs attention

rpmlint output:
$ rpmlint python-pbs \
          python-pbs-4.3.0-3.fc15.src.rpm \
          python-pbs-debuginfo-4.3.0-3.fc15.i686.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Rpmlint is quiet
+ The package is named according to the Package Naming Guidelines.
+ Spec file name matches the base package name
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
! The license file (LICENSE.openpbs) isn't included in the package
+ Spec file is written in American English
+ Spec file is legible
+ Following instructions in the spec file to check out sources
+ Upstream sources match sources in the srpm. md5sum:
  34fada5c56322fac6254d6bf9c9c9106  pbs_python-4.3.0.tar.gz
  34fada5c56322fac6254d6bf9c9c9106  Download/pbs_python-4.3.0.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ Consistent use of macros
+ The package must contain code, or permissable content.
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc don't affect the package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Package doesn't contain any libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8


MUSTFIX:
 - Include the LICENSE.openpbs file in %doc for both subpackages

Some additional nitpicking:
 - Also consider including the AUTHORS and CHANGES files in %doc
 - python-pbs and %{altpython}-pbs subpackages have different Group tags; might
   make sense to put them both into same group. Also, if you use same group,
   then you only have to specify Group tag for main package and the subpackage
   inherits it automatically.
 - %descriptions for both subpackages still refer to 'pbs_python' package name

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.