[Bug 656938] Review Request: python-shapely - Geometric objects, predicates, and operations

bugzilla at redhat.com bugzilla at redhat.com
Fri Nov 26 21:01:10 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=656938

Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Rex Dieter <rdieter at math.unl.edu> 2010-11-26 16:01:03 EST ---
* rpmlint clean

* sources: OK
$ md5sum *.gz
2cd0bab00a2c39d1ae6cd9ed648db904  Shapely-1.2.7.tar.gz

* naming ok

* license ok

* installs/runs ok (performed only very basic tests)

* %files ok  (but see next...)

* SHOULD: please document why
%exclude %{_bindir}/intersect.py
%exclude %{_bindir}/dissolve.py

* SHOULD: consider adding a %check section with:
$ python setup.py test
fwiw, I see 3 failures on my f14 box (once I installed numpy), though at least
one is due to some slight rounding differences.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list