[Bug 588941] Review Request: pypy - Implementation of the Python language, using Python itself

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588941

--- Comment #11 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2010-11-27 16:12:44 EST ---
I don't really want to be primary maintainer but I'd be happy to comaintain
once this is reviewed and in the distro and I can also work on addressing at
least some of the review blockers.  So I've got an updated package here:

http://toshio.fedorapeople.org/packages/pypy-1.4-2.fc13.src.rpm
http://toshio.fedorapeople.org/packages/pypy.spec

Working its way through the build system here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2629927

If it fails to build in the buildsystem, I'll take another crack at it this
weekend.

Things fixed:

1) License tag is better.  dmalcolm:  I found the list of licenses that had
been included in the spec file present in the LICENSE file.  If that's where
you got the original list from then the license tag should now be correct.  I
was able to remove LGPL and Distributable because those were coming from
bundled jar files.  I removed the bundled jars (see below) so that should now
be fine.

2) The Source0 is now a URL to upstream.

3) pypy-libs Req now versioned

4) The build isn't make driven but I didn't look at parallelizing it.

5) rpmlint c): Yeah, it's because it's named -libs.  Another possible name is
-stdlib since it is the python stdlib(for pypy).

5e) I was waiting for the koji build to complete to see if this is still an
issue with 1.4.

5f) dmalcolm, what did we decide to do with this on the python and python3
packages?

Other:
* Removed bundled jar files.  Pre-built files are not allowed.  It looks like
these were present in case we were building a pypy that targets the jvm (rather
than POSIX-C).  Simple removal should be fine until/unless we want to enable
that backend.  If we do enable that, one of the jar files is packaged for
Fedora (jna) but the other (jasmin) is not.
* Build pypy with itself after the first build as upstream recommends this now
(and it's supposed to be faster than using cpython)
* Build the jit'ed version on both x86 and x86_64 (1.4 feature)
* It looked like we weren't picking up the CFLAGS so I added a patch to pick up
the CFLAGS environment variable
* In the same patch, the code that configures for linux was mandating a static
libffi.  I changed that so that the shared libffi should be picked up.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.