[Bug 604031] Review Request: kde-plasma-kprayertime - Displays Islamic prayer Time

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604031

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #1 from Volker Fröhlich <volker27 at gmx.at> 2010-11-27 17:08:04 EST ---
* rpmlint clean

* sources: OK
$ md5sum kprayertime4.01.src.tar.gz 
098682e4b6c6b5b1f5caf68f4d3ca412  kprayertime4.01.src.tar.gz

* license ok

* builds on F13, F14 and Rawhide

* installs/runs ok

* files ok

I'm not really sure, if upstream calls it kde-plasma-kprayertime or
kde-plasma-kprayertime4.

I think it is prefered to write "BuildRequires: cmake gettext" instead of
"BuildRequires: cmake,gettext". Your package doesn't seem to need gettext,
since no translations are included.

I think the description should end with a period. The capitalization of
"Islamic Prayer time" is also different for the description and the summary.

You may have to add these two lines, since your package introduces a shared
library.

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.