[Bug 647510] Review Request: premake - A cross-platform build configuration tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647510

--- Comment #9 from Dan Horák <dan at danny.cz> 2010-11-28 05:50:13 EST ---
(In reply to comment #8)
> Changes:
>   - packed latest version
>   - changes license to BSD
>   - added readline-devel to BuildRequires
>   - added a man page
>   - do not clean %{_builddir}/%{buildsubdir}
>   - added version-release pair to changelog

all issues mentioned in the review are fixed, but a new one appeared
- you shouldn't compress the man page during install, it's done automagically
by rpm, also use wild-carded form "premake4.1*" in %files as the algorithm can
change

For the records - sha1sum of the source archive
8f37a3599121580f18b578811162b9b49a2e122f  premake-4.3-src.zip

Also thanks for preparing the man page, did you sent it to upstream for
inclusion in the new release of premake?

> The provided test suite could be run during the build, but unfortunately one
> test fails on x86_64, so I chose not to add it. I'll report the bug upstream
> and run the tests when it has been fixed:
> 
>   os.findlib_FindSystemLib:
> /home/joachim/tmp/premake-4.3/tests/base/test_os.lua:18: expected true but was
> false
>   600 tests passed, 1 failed

thanks for the information, hopefully they will solve the issue and the
test-suite could be enabled in the future

> I'm not sure about the symlink, as upstream calls the current version premake4
> throughout the documentation and chosen this name as the scripts for version 4
> are incompatible to scripts for the previous versions.

yes, you are right with incompatibilities, let's keep only the binary

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.