[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657908

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de> 2010-11-30 03:07:30 EST ---
Hi Volker,

here are some initial comments on your spec:

- adapt Source0 according to
  http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

- If you plan to maintain this package for EPEL < 6 too, please add a 
  BuildRoot tag. Otherwise, you can also drop the %clean section and
  rm -rf %{buildroot} from %install. 

- replace %{_mandir}/man1/%{name}.1.gz
  with %{_mandir}/man1/%{name}.1*
  since you should not rely on a specific compression format applied by 
  rpmbuild because it might change

- add the %doc files NEWS, README, TODO 

- I also recommend to add the sample configuration files as %doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.