[Bug 631763] Review Request: zif - Simple wrapper for rpm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=631763

--- Comment #5 from Richard Hughes <rhughes at redhat.com> 2010-10-01 09:39:54 EDT ---
(In reply to comment #2)
> > %define alphatag                .20100908git
> This macro is not used anywhere. Also, %global is preferred to %define these
> days.

Eeek, sorry, that got left in from my initial package that was based on the git
checkout. Removed now.

> > %package devel
> [...]
> > Requires: sqlite-devel
> 
> %{?_isa} would be nice here.
> http://www.rpm.org/wiki/PackagerDocs/ArchDependencies

Fixed.

> > %package devel
> [...]
> > Requires: %{name} = %{version}-%{release}
> [...]
> > %files
> > %defattr(-,root,root,-)
> > %doc README AUTHORS NEWS COPYING
> > [...]
> > %files devel
> > %defattr(-,root,root,-)
> > %doc README AUTHORS NEWS COPYING
> 
> No need to duplicate these files here, because -devel Requires the main
> package.

Fixed, thanks.

(In reply to comment #3)
> The files in %{_datadir}/gtk-doc/html/zif/ look like developer's documentation
> to me. Wouldn't they be better placed in the -devel package?

Yup, oops, thanks. New spec and SRPMS for review:

http://people.freedesktop.org/~hughsient/temp/zif.spec
http://people.freedesktop.org/~hughsient/temp/zif-0.1.0-2.fc14.src.rpm

Richard.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.