[Bug 631763] Review Request: zif - Simple wrapper for rpm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=631763

--- Comment #11 from Richard Hughes <rhughes at redhat.com> 2010-10-01 13:43:44 EDT ---
(In reply to comment #10)
>   [??] Requires
>     I wonder what is special about sqlite-devel that it is required
>     explicitly by zif-devel, but libarchive-devel is left to be pulled
>     automatically via rpm's pkgconfig dependency extraction.

You're correct. sqlite-devel gets pulled in automatically. I've removed that
line.

>   [!!] macros
>      %{_mandir} should be used instead of %{_datadir}/man/

Fixed.

>     %{_datadir}/gtk-doc/html is owned neither by zif-devel nor any
>     Required package. Should Require gtk-doc?

I wasn't sure. Looking into it, I shouldn't just add a Req for gtk-doc, as
there's been a big push to not pull it in unless it's really required. I've
just taken ownership of all the gtk-doc directory, like has been done to my
other packages by other people.

> [!!] owning of directories, already noted above

Fixed.

New spec and SRPMS for review:

http://people.freedesktop.org/~hughsient/temp/zif.spec
http://people.freedesktop.org/~hughsient/temp/zif-0.1.0-4.fc14.src.rpm

Thanks,

Richard.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.