[Bug 638127] Review Request: motoya-lmaru-fonts - Japanese Round Gothic-typeface TrueType fonts by MOTOYA Co,LTD

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 4 01:59:12 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638127

Daiki Ueno <dueno at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |dueno at redhat.com
         AssignedTo|nobody at fedoraproject.org    |dueno at redhat.com
               Flag|                            |fedora-review+

--- Comment #1 from Daiki Ueno <dueno at redhat.com> 2010-10-03 21:59:10 EDT ---
- rpmlint is silent.
- repo-font-audit reports 4 warnings, but most of them are upstream task (one
is "bad font naming", but I think we can ignore it this time).

Looks fine.

Suggestions:
1) "archivename" is defined but not used
2) If package is needed only for F-13 and above then you can do following in
spec
   a) %clean not needed
   b) cleaning of buildroot at start of %install also not needed

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list