[Bug 636946] Review Request: perl-Astro-FITS-Header - Object Orientated interface to FITS HDUs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636946

--- Comment #3 from Petr Pisar <ppisar at redhat.com> 2010-10-04 09:18:10 EDT ---
Changes:

--- perl-Astro-FITS-Header.spec 2010-09-23 20:24:18.000000000 +0200
+++ perl-Astro-FITS-Header.spec.1 2010-10-04 14:19:09.000000000 +0200
@@ -6,10 +6,12 @@
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Astro-FITS-Header/
 Source0:       
http://www.cpan.org/authors/id/T/TJ/TJENNESS/Astro-FITS-Header-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:      noarch
 BuildRequires:  perl(ExtUtils::MakeMaker)
+# test BR
 BuildRequires:  perl(Test::More)
+#  perl(Starlink::AST),perl(NDF), perl(GSD)
+BuildRequires:  perl(File::Spec), perl(Astro::FITS::CFITSIO)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

 %description


> FIX: Missing BuildRequires for %check phase: perl(Starlink::AST),
> perl(Astro::FITS::CFITSIO), perl(GSD), perl(NDF)
Available %check-dependecies added. Ok.
TODO: Package %check-time dependencies to enable all tests.

> $ rpmlint perl-Astro-FITS-Header.spec
> ../SRPMS/perl-Astro-FITS-Header-3.01-1.fc13.src.rpm
> ../RPMS/noarch/perl-Astro-FITS-Header-3.01-1.fc13.noarch.rpm 
> perl-Astro-FITS-Header.spec: W: no-cleaning-of-buildroot %clean
> perl-Astro-FITS-Header.spec: W: no-%clean-section
> perl-Astro-FITS-Header.src: W: spelling-error %description -l en_US arguement
> -> argument, arrangement, enlargement
> perl-Astro-FITS-Header.src: W: no-cleaning-of-buildroot %clean
> perl-Astro-FITS-Header.src: W: no-%clean-section
> perl-Astro-FITS-Header.noarch: W: spelling-error %description -l en_US
> arguement -> argument, arrangement, enlargement
> 2 packages and 1 specfiles checked; 0 errors, 6 warnings.
> 
> FIX: Description spelling is incorrect.
TODO: Fix the spelling (arguement → argument).

> FIX: Missing perl(File::Spec) BuildRequires for %check phase (dual-life
> package possible).
Ok.

Builds on F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2510543).

# LANG=en yum --nogpgcheck localinstall
~test/rpmbuild/RPMS/noarch/perl-Astro-FITS-Header-3.01-1.fc15.noarch.rpm
Failed to set locale, defaulting to C
Setting up Local Package Process
Examining
/home/test/rpmbuild/RPMS/noarch/perl-Astro-FITS-Header-3.01-1.fc15.noarch.rpm:
perl-Astro-FITS-Header-3.01-1.fc15.noarch
Marking
/home/test/rpmbuild/RPMS/noarch/perl-Astro-FITS-Header-3.01-1.fc15.noarch.rpm
to be installed
Resolving Dependencies
--> Running transaction check
---> Package perl-Astro-FITS-Header.noarch 0:3.01-1.fc15 set to be installed
--> Processing Dependency: perl(GSD) for package:
perl-Astro-FITS-Header-3.01-1.fc15.noarch
--> Processing Dependency: perl(NDF) for package:
perl-Astro-FITS-Header-3.01-1.fc15.noarch
--> Processing Dependency: perl(Starlink::AST) for package:
perl-Astro-FITS-Header-3.01-1.fc15.noarch
--> Finished Dependency Resolution
Error: Package: perl-Astro-FITS-Header-3.01-1.fc15.noarch
(/perl-Astro-FITS-Header-3.01-1.fc15.noarch)
           Requires: perl(GSD)
Error: Package: perl-Astro-FITS-Header-3.01-1.fc15.noarch
(/perl-Astro-FITS-Header-3.01-1.fc15.noarch)
           Requires: perl(Starlink::AST)
Error: Package: perl-Astro-FITS-Header-3.01-1.fc15.noarch
(/perl-Astro-FITS-Header-3.01-1.fc15.noarch)
           Requires: perl(NDF)
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest
FIX: Package necessary packages to resolve missing binary dependencies
(perl(GSD), perl(NDF), perl(Starlink::AST)), or filter them from Requires. Make
sure the package remains useful.


Please fix all `FIX:' prefixed comments and publish new spec file.
Result: NOT APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.