[Bug 638974] Review Request: erlang-protobuffs - A set of Protocol Buffers tools and modules for Erlang applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638974

Nathaniel McCallum <nathaniel at natemccallum.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nathaniel at natemccallum.com
         AssignedTo|nobody at fedoraproject.org    |nathaniel at natemccallum.com
               Flag|                            |fedora-review?

--- Comment #1 from Nathaniel McCallum <nathaniel at natemccallum.com> 2010-10-04 14:38:06 EDT ---
[  OK  ] specfiles match: 05114befc722dc9d5160b22246bba92c
[  OK  ] source files match upstream: ef08e31d3b08548d820e9508de57a31d
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[ FAIL ] license field matches the actual license.
License is MIT, not BSD.
[  OK  ] license is open source-compatible.
[  NA  ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  OK  ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
[  OK  ] package installs properly.
[  OK  ] debuginfo package looks complete.
[  OK  ] rpmlint is silent.
erlang-protobuffs.ppc: E: explicit-lib-dependency erlang-stdlib
erlang-protobuffs.ppc: E: no-binary
erlang-protobuffs.ppc: W: only-non-binary-in-usr-lib
These are all false positives.
[  OK  ] final provides and requires are sane
[  OK  ] %check is present and all tests pass:
[  OK  ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  OK  ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] no headers.
[  OK  ] no pkgconfig files.
[  OK  ] no libtool .la droppings.
[  OK  ] desktop files valid and installed properly.

Fix the license and we are good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.