[Bug 639351] Review Request: gtk-sharp-beans - C# bindings for GTK+ API not included in GTK#

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639351

Peter Lemenkov <lemenkov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #6 from Peter Lemenkov <lemenkov at gmail.com> 2010-10-05 02:50:08 EDT ---
Koji scratch build for Rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2513383

REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is almost silent

Sulaco ~/rpmbuild/SPECS: rpmlint  ~/Desktop/gtk-sharp-beans-*
gtk-sharp-beans.i686: E: no-binary
gtk-sharp-beans.i686: W: only-non-binary-in-usr-lib
gtk-sharp-beans-devel.i686: W: no-documentation
2 packages and 0 specfiles checked; 1 errors, 2 warnings.
Sulaco ~/rpmbuild/SPECS:

These messages should be ignored - they are caused by fact that we're
installing (almost) arch-independent binary data into arch-dependent directory.
In fact C# binary data is arch-dependent but rpmlint doesn't know about it yet.

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license (LGPLv2
only)
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.

Sulaco ~/rpmbuild/SOURCES: sha256sum
mono-gtk-sharp-beans-2.14.0-0-ga2ff3c5.tar.gz*
91fe411ac6889bcf6b70074f3c0dc62de9076a43e804fd7cc2009f8b008dbd6b 
mono-gtk-sharp-beans-2.14.0-0-ga2ff3c5.tar.gz
91fe411ac6889bcf6b70074f3c0dc62de9076a43e804fd7cc2009f8b008dbd6b 
mono-gtk-sharp-beans-2.14.0-0-ga2ff3c5.tar.gz.1
Sulaco ~/rpmbuild/SOURCES:

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
+ The "devel" sub-package requires the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}/
+ The pkgconfig(.pc) file is properly placed in *-devel sub-package and
necessary runtime dependency is added.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.

this package is 

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.