[Bug 637378] Review Request: rubygem-aws - Ruby gem for all Amazon Web Services

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 5 10:55:21 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637378

--- Comment #4 from Michal Fojtik <mfojtik at redhat.com> 2010-10-05 06:55:20 EDT ---
(In reply to comment #2)
> Well,
> 
> * Functionality
>   - First of all:
> ---------------------------------------------------------------
> [root at localhost i686]# irb
> rirb(main):001:0> require "rubygems"
> erqu=> true
> irb(main):002:0> require "aws"
> Gem::LoadError: Could not find RubyGem http_connection (>= 0)
> 
>         from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:779:in
> `report_activate_error'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:214:in `activate'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:249:in `activate'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:248:in `each'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:248:in `activate'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:35:in
> `require'
>         from (irb):2
> ---------------------------------------------------------------
>     Actually what is really needed is "right_http_connection", however
>     metadata.gz in gem file has mistake.

Nice catch, fixed this one in gemspec.

> 
>   - Then after installed gemspec file is fixed so that aws.gem requires
>     right_http_connection correctly, activating aws still fails like:
> ---------------------------------------------------------------
> irb(main):001:0> require "rubygems"
> => true
> irb(main):002:0> require "aws"
> LoadError: no such file to load -- active_support
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in
> `gem_original_require'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in
> `require'
>         from
> /usr/lib/ruby/gems/1.8/gems/aws-2.3.21/lib/awsbase/right_awsbase.rb:31
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in
> `gem_original_require'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in
> `require'
>         from /usr/lib/ruby/gems/1.8/gems/aws-2.3.21/lib/aws.rb:18
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in
> `gem_original_require'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in
> `require'
>         from (irb):2
> ---------------------------------------------------------------
>     So "R:  rubygem(activesupport)" is needed.

Fixed. Dependency added.

> 
>   - And even if rubygem-activesupport is installed (after gemspec file is
> fixed),
>     still aws cannot be activated like:
> ---------------------------------------------------------------
> irb(main):001:0> require "rubygems"
> => true
> irb(main):002:0> require "aws"
> ArgumentError: wrong number of arguments (2 for 1)
>         from
> /usr/lib/ruby/gems/1.8/gems/aws-2.3.21/lib/awsbase/support.rb:49:in `const_get'
>         from
> /usr/lib/ruby/gems/1.8/gems/aws-2.3.21/lib/awsbase/support.rb:49:in
> `constantize'
>         from
> /usr/lib/ruby/gems/1.8/gems/aws-2.3.21/lib/awsbase/support.rb:48:in `each'
>         from
> /usr/lib/ruby/gems/1.8/gems/aws-2.3.21/lib/awsbase/support.rb:48:in
> `constantize'
>         from
> /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.8/lib/active_support/dependencies.rb:529:in
> `new_constants_in'
>         from
> /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.8/lib/active_support/dependencies.rb:525:in
> `collect'
>         from
> /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.8/lib/active_support/dependencies.rb:525:in
> `new_constants_in'
>         from
> /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.8/lib/active_support/dependencies.rb:156:in
> `require'
>         from
> /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.8/lib/active_support.rb:58
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in
> `gem_original_require'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in
> `require'
>         from
> /usr/lib/ruby/gems/1.8/gems/aws-2.3.21/lib/awsbase/right_awsbase.rb:31
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in
> `gem_original_require'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in
> `require'
>         from /usr/lib/ruby/gems/1.8/gems/aws-2.3.21/lib/aws.rb:18
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in
> `gem_original_require'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in
> `require'
>         from (irb):2
> ---------------------------------------------------------------
>     It seems that the following patch is needed.
> ---------------------------------------------------------------
> --- lib/awsbase/support.rb.debug 1970-01-01 09:00:00.000000000 +0900
> +++ lib/awsbase/support.rb 2010-10-05 06:18:52.000000000 +0900
> @@ -46,7 +46,10 @@
> 
>              constant = Object
>              names.each do |name|
> -                constant = constant.const_get(name, false) ||
> constant.const_missing(name)
> +                constant = ( 
> +                    ( RUBY_VERSION >= "1.9" ? constant.const_get(name, false)
> : constant.const_get(name) ) || 
> +                    constant.const_missing(name) 
> +                    )
>              end
>              constant
>          end
> ---------------------------------------------------------------

Patch added. Thanks for creating it. I was dealing with this issue as well
but I forgot including this patch in package.

> 
> * Directory ownership issue
>   - Currently the directory %geminstdir itself is not owned by any packages.
> * BR
>   - Would you check if "BR: rubygem(rake) rubygem(rspec)" are really needed?

Fixed and Removed.

Now the file:

http://mifo.sk/RPMS/rubygem-aws-2.3.21-2.fc13.src.rpm
http://mifo.sk/RPMS/rubygem-aws.spec

Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2513686

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list