[Bug 637448] Review Request: rubygem-glib2 - Ruby binding of GLib-2.x

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637448

Michal Fojtik <mfojtik at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #6 from Michal Fojtik <mfojtik at redhat.com> 2010-10-05 08:45:37 EDT ---
REVIEW:

[OK] Packages that contain Ruby Gems must be called rubygem-%{gemname} where
gemname is the name from the Gem's specification.

[OK] The Source of the package must be the full URL to the released Gem
archive; the version of the package must be the Gem's version

[OK] The package must have a Requires and a BuildRequires on rubygems

[OK] The package must provide rubygem(%{gemname}) where gemname is the name
from the Gem's specification.

[OK] For every dependency on a Gem named gemdep, the package must contain a
Requires on rubygem(%{gemdep}) with the same version constraints as the Gem

[OK] The Gem must be installed into %{gemdir} defined as
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
The install should be performed with the command

gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}
The package must own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec

[OK] Architecture-specific content must not be installed into %{gemdir}

[OK] %prep stage must contain %setup -q -c -T to create the directory where C
libraries are compiled.

Package looks good, builds without errors/warning under Koji, rpmlint is quite.
Setting REVIEW+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.