[Bug 637923] Review Request: firmware-extract - A firmware-tools plugin to add firmware extraction from vendor binaries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637923

--- Comment #3 from Praveen K Paladugu <praveen_paladugu at dell.com> 2010-10-06 09:27:02 EDT ---


1) Please remove the suse related macros from the spec file.
2) Please update the pythong_sitelib definition with conditionals as shown at:
http://fedoraproject.org/wiki/Packaging:Python#Macros 
3) I don't see a need for the following lines in the spec file: 
touch configure
find . -type f -newer configure -print0 | xargs -r0 touch

4) Please update the spec file to use either $RPM_BUILD_ROOT/%{buildroot}
instead of both. 

5) Please add a changelog comment to be in consistent with the current
versioning.


Nothing stands out in the rpmlint errors :).

Praveen

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.