[Bug 640337] Review Request: perl-MooseX-NonMoose - Easy subclassing of non-Moose classes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=640337

--- Comment #4 from Ralph Bean <ralph.bean at gmail.com> 2010-10-06 11:00:40 EDT ---
Ok, then I believe the name of the spec and srpm should be changed from
*.fc13.* to *.fc14.*

Besides that, here's my stab:

OK:
* The name/version match
http://fedoraproject.org/wiki/Packaging:NamingGuidelines
* License: OK
* No inclusion of pre-built binaries
* Spec is legible
* RPMLINT:
  * perl-MooseX-NonMoose.src: W: no-cleaning-of-buildroot %clean
    * but this is okay >= fc10
  * perl-MooseX-NonMoose.src: W: no-buildroot-tag
    * but this is okay >= fc10
  * perl-MooseX-NonMoose.src: W: no-%clean-section
    * but this is okay >= fc13
* Description is good
* BuildRequires and Requires are all good
* Documentation from upstream is good
* Good default file permissions
* The source is the same as upstream
* Perl specific stuff looks in-line with 
  * http://fedoraproject.org/wiki/Packaging:Perl
* mock runs fine for fc14

Needs Work:
  Only the .fc13. -> .fc14. name change.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.