[Bug 637923] Review Request: firmware-extract - A firmware-tools plugin to add firmware extraction from vendor binaries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637923

--- Comment #4 from Michael E Brown <michael_e_brown at dell.com> 2010-10-06 12:43:53 EDT ---
1) there are two compat statements for suse compatibility. (6 total LOC, plus
associated comments) This is not excessive and doesnt violate packaging
standards, as far as I know.

2) The %{!? construct will only define the macro if it is not already defined.
Thus, adding an %if only adds extra lines of code without technically changing
the behaviour at all. I've changed the comment.

3) I've seen problems on when the system I create the tarball on has a time
that is faster than the buildsystem time. These two lines fix the build for
this corner case. I've removed them for now, as the build system which I used
that had this problem seems to be fixed now.

4) Fixed.

5) fixed

I've pushed the spec file updates to master git, but I have not created a new
release since this was only spec updates without code changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.