[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=626458

--- Comment #3 from Kalev Lember <kalev at smartlink.ee> 2010-10-06 16:33:04 EDT ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2518427

I have a few initial comments, but none of them is a review blocker. Just some
small things you might want to change before importing the package into git.


How did upstream react to the libmnetutil-0001-Remove-bundled-udns.patch? Looks
like the patch removes all of the udns source files. If upstream doesn't want
to take the patch like this, another option would be to rework it so that the
configure script gets an option to choose between bundled or system copy of
udns.


> %package devel
...
> Requires:               pkgconfig

In Fedora 12+ rpmbuild generates the pkgconfig dependency automatically for
subpackages which ship .pc files. It is however needed for EL5 and older. So if
you only intend to package it in Fedora, you might want to remove that line.


> %package devel
> ...
> Requires:               automake
> ...
> %files devel
> ...
> %{_datadir}/aclocal/*.m4

A recent change in packaging guidelines suggests to use multiple directory
ownership to avoid dragging in other packages which wouldn't be otherwise
needed for normal functioning. I guess automake would fall under that category
too.

https://fedoraproject.org/wiki/Packaging/Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.