[Bug 640215] Review Request: apache-commons-dbcp - rename of jakarta-commons-dbcp

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 7 09:30:16 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


Alexander Kurtakov <akurtako at redhat.com> changed:

           What    |Removed                     |Added
               Flag|                            |fedora-review+

--- Comment #2 from Alexander Kurtakov <akurtako at redhat.com> 2010-10-07 05:30:16 EDT ---
[X]  Rpmlint output:
apache-commons-dbcp-javadoc.noarch: W: obsolete-not-provided
apache-commons-dbcp.noarch: W: obsolete-not-provided
apache-commons-dbcp.noarch: W: obsolete-not-provided hibernate_jdbc_cache
OK, we should not keep dummy provides.

apache-commons-dbcp.noarch: W: non-conffile-in-etc
False positive.
[X]  Package is named according to the Package Naming Guidelines[1].
[X]  Spec file name must match the base package name, in the format
[X]  Package meets the Packaging Guidelines[2].
[X]  Package successfully compiles and builds into binary rpms.
[X]  Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[X]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
[X]  License field in the package spec file matches the actual license.
License type:
[X]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[X]  All independent sub-packages have license of their own
[X]  Spec file is legible and written in American English.
[X]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package    :e9f599c99baefeeb0e192030c5d19d5d
MD5SUM upstream package:e9f599c99baefeeb0e192030c5d19d5d
[X]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[X]  Package must own all directories that it creates.
[X]  Package requires other packages for directories it uses.
[X]  Package does not contain duplicates in %files.
[X]  Permissions on files are set properly.
[X]  Package has a %clean section, which contains rm -rf %{buildroot} (or
[X]  Package consistently uses macros.
[X]  Package contains code, or permissable content.
[X]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
[X]  Package does not own files or directories owned by other packages.
[X]  Javadoc documentation files are generated and included in -javadoc
[X]  Packages have proper BuildRequires/Requires on jpackage-utils
[X]  Javadoc subpackages have Require: jpackage-utils
[X]  Package uses %global not %define
[-]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-]  If source tarball includes bundled jar/class files these need to be
removed prior to building
[X]  All filenames in rpm packages must be valid UTF-8.

=== Maven ===
[X]  Use %{_mavenpomdir} macro for placing pom files instead of
[X]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a
[X]  If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why
it's needed in a comment
[X]  Package uses %update_maven_depmap in %post/%postun
[X]  Packages have Requires(post) and Requires(postun) on jpackage-utils (for
%update_maven_depmap macro)

=== Other suggestions ===
[X]  If possible use upstream build method (maven/ant/javac)
[X]  Javadocs are placed in %{_javadocdir}/%{name}-%{version} with
%{_javadocdir}/%{name} symlink
[X]  Jar files are installed to %{_javadir}/%{name}-%{version}.jar with
%{_javadir}/%{name}.jar (unversioned) symlink
[X]  If package contains pom.xml files install it (including depmaps) even when
building with ant 
[X]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[X]  Latest version is packaged.
[X]  Reviewer should test that the package builds in mock.

Really good package, can serve as an example.

This package is APPROVED.

Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list