[Bug 640205] Review Request: visualvm - Lightweight profiler that integrates many command-line JDK tools

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 7 14:35:22 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=640205

--- Comment #11 from Stanislav Ochotnicky <sochotni at redhat.com> 2010-10-07 10:35:21 EDT ---
(In reply to comment #10)
> > visualvm.x86_64: E: zero-length
> > /usr/lib64/visualvm/visualvm/config/Modules/org-netbeans-modules-options-keymap.xml_hidden
> > ...
> > visualvm.x86_64: E: zero-length /usr/lib64/visualvm/profiler/.lastModified
> >  -Upstream generates them and it is best not to delete them as upstream may
> > rely on them for something.
> >
> > visualvm.x86_64: W: hidden-file-or-dir
> > /usr/lib64/visualvm/profiler/.lastModified
> >  -Added by upstream build.
> 
> Are they really needed? "Upstream may rely on them for something" is not the
> answer. If you can't figure out if these files are really needed, ask upstream.
> If there is no other way, remove these empty files and re-create them in post
> (remove in postun). Though I very much doubt it would harm anything if they
> were missing.

.lastModified files should be created in %post (removed in %postun). See
http://bits.netbeans.org/dev/javadoc/org-netbeans-bootstrap/overview-summary.html#java.io.File-.lastModified

As for the other zero-length files. I don't know their function, but unless we
find a reason for them to stay they should be removed

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list