[Bug 640205] Review Request: visualvm - Lightweight profiler that integrates many command-line JDK tools

Fri Oct 8 15:50:18 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=640205

--- Comment #18 from Stanislav Ochotnicky <sochotni at redhat.com> 2010-10-08 11:50:17 EDT ---
Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!]  Rpmlint output:
visualvm.src: W: spelling-error Summary(en_US) profiler -> profile, profiles,
profiled
OK

visualvm.src: W: patch-not-applied Patch0: visualvm-debuginfo.patch
explained 

visualvm.x86_64: W: non-etc-or-var-file-marked-as-conffile
/usr/lib64/visualvm/etc/visualvm.clusters
visualvm.x86_64: W: non-etc-or-var-file-marked-as-conffile
/usr/lib64/visualvm/etc/visualvm.conf

so once again...Why didn't you use --sysconfdir switch to configure?

visualvm.x86_64: W: dangling-symlink /usr/lib64/visualvm/platform
/usr/share/netbeans/platform12

explained

visualvm.x86_64: W: no-manual-page-for-binary jvisualvm
visualvm.x86_64: W: non-standard-dir-in-usr jvm
I'll get to this further down

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
It's actually
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
So while you're making other changes please change this as well

[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: GPLv2 with exceptions
[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[-]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package    : 3dac8c562bc847d2782bdc192826271f
MD5SUM upstream package: 3dac8c562bc847d2782bdc192826271f

netbeans-profiler: aeca7cbd0f1dfb30858d80fa1e150820
visualvm_13: f1a28e24451982114be6590ceddeae12

[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[!]  Package requires other packages for directories it uses.
/usr/lib[64]/visualvm directory doesn't seem to be provided by any
other package and this one doesn't include it either

[!]  Package does not contain duplicates in %files.
files /usr/jvm/java-openjdk-jvisualvm/bin/jvisualvm
and /usr/bin/jvisualvm
are the same

plus file /usr/jvm/java-openjdk-jvisualvm/share/visualvm.desktop is in
wrong place (you can just delete it since you have desktop file in
right place as well)

[x]  Permissions on files are set properly.
[x]  Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x]  Package consistently uses macros.
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[x]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x]  Package does not own files or directories owned by other packages.
[!]  Package uses %global not %define
replace your %define-s with %global
[-]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[!]  If source tarball includes bundled jar/class files these need to
be removed prior to building

there is file nbbuild/sierra/build.jar in
netbeans-profiler-visualvm_release69.tar.gz

File includes *java file so it should be possible to re-create it
should it be necessary. Since the upstream tarball contains
binary file you'll have to unpack & clean & repack prior to building
visualvm (or create script to do it and include modified version in
SourceX:)

[x]  All filenames in rpm packages must be valid UTF-8.

=== Other suggestions ===
[-]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[x]  Reviewer should test that the package builds in mock.
Tested on: fedora-rawhide-x86_64

=== Issues ===
1. etc directory placement
2. ownership of /usr/lib[64]/visualvm directory
3. duplicate files in /usr/jvm (and existence of this directory)
4. define -> global macro
5. bundled build.jar inside netbeans tar.gz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.