[Bug 641295] Review Request: rubygem-typhoeus - A library for interacting with web services at blinding speed

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641295

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-10-08 15:36:42 EDT ---
Some notes:

* Unused macro
  - Defined %ruby_sitelib macro is used nowhere.

* License
  - License tag should be "MIT".

* (Build)Requires
  - ">= 0" part is not needed.
  - "BR: libcurl" is written twice, and anyway this is not needed
    because "BR: libcurl-devel" also exists and libcurl-devel
    requires libcurl.

* Provides
  - Would you explain why rubygem-typhoeus-devel should have
    "Provides: ruby-typhoeus-devel" and 
    "Provides: ruby(typhoeus-devel)"?
    ! Note that for example rubygem-glib2-devel has 
      Provides: ruby-glib2-devel is because there was actually
      "ruby-glib2-devel" package, and ruby-glib2-devel "wrongly"
      provided ruby(glib2-devel)" (so the latter Provides is
      only for compatibility for old Provides).
    ! Also, currently rubygem-typhoeus-devel has
      "Provides: ruby-%{name}-devel", where %{name} is expanded
      as rubygem-typhoeus (so as a whole it is expanded as
      ruby-rubygem-typhoeus-devel)

* Fedora specific compilation flags
-------------------------------------------------------------
    88  make
    89  gcc -I. -I. -I/usr/lib/ruby/1.8/i386-linux -I. -D_FILE_OFFSET_BITS=64 
-fPIC -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables  -g -DXP_UNIX -O3 -Wall -Wcast-qual
-Wwrite-strings -Wconversion -Wmissing-noreturn -Winline  -c typhoeus_multi.c
-------------------------------------------------------------
  - Here Fedora specific compilation flags (%optflags) uses -O2
    but this is replaced by the latter -O3 flag, which needs fixing.
    This "-O3" flag comes from ext/typhoeus/extconf.rb, so this
    can be fixed only after executing "gem install", then
    fix ext/typhoeus/extconf.rb and recompiling (by $ ruby extconf.rb
    -> make clean all )

* Directory ownership issue
  - The directory %{ruby_sitearch}/typhoeus/ itself is not owned
    by any packages.

* ext/ directory
  - Would you explain why files in ext/ directory have to be installed?
    (usually this directory should not be needed)

! %check
  - Usually when the directory spec/ exists, I request to add %check section
    and execute $ rake spec there, however for this gem many test case
    fail with no rails server running...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.